feat: Add OCIVPN entity definition (staging)#3065
Conversation
entityBot
left a comment
entityBot
left a comment
There was a problem hiding this comment.
We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.
46911e4 to
fe65bd2
Compare
entityBot
left a comment
entityBot
left a comment
There was a problem hiding this comment.
beep boop bop.
I have found some errors processing these changes:
- Error VALIDATING domainType: 'INFRA-OCIVPN' on synthesis - Exception: No entity matches 'INFRA-OCIVPN' synthesis rules for the given test data: 'MetricRaw.json file - #1' data point. Please review test data and synthesis rules.
- We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the
ARB:pendinglabel. Reach#api-review-boardin case of doubts.
Dismissing reviews
entityBot
left a comment
entityBot
left a comment
There was a problem hiding this comment.
beep boop bop.
I have found some errors processing these changes:
- Error VALIDATING domainType: 'INFRA-OCIVPN' on synthesis - Exception: No entity matches 'INFRA-OCIVPN' synthesis rules for the given test data: 'MetricRaw.json file - #1' data point. Please review test data and synthesis rules.
- We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the
ARB:pendinglabel. Reach#api-review-boardin case of doubts.
Add OCI Site-to-Site VPN (IPSec) entity definition with: - Entity definition with synthesis rule (prefix ocid1.ipsecconnection, namespace oci_vpn) - Golden metrics (tunnel state, bytes sent/received, packets with errors) - Summary metrics - Test data - Using .stg.yml/.stg.json suffix (staging only) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
b8b2ec9 to
d808704
Compare
entityBot
left a comment
entityBot
left a comment
There was a problem hiding this comment.
We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.
entityBot
left a comment
entityBot
left a comment
There was a problem hiding this comment.
We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.
entityBot
left a comment
entityBot
left a comment
There was a problem hiding this comment.
We don't think these changes require an API Review Board (ARB) review, so it is not required to merge this PR. Note that all API changes do require one: if you believe this PR needs an ARB review, please create the ticket and add the ARB:pending label. Reach #api-review-board in case of doubts.
4 participants
Add OCI Site-to-Site VPN (IPSec) entity definition with synthesis rule, golden metrics, and summary metrics. Staging (
.stg.yml/.stg.json).Entity Type
INFRA-OCIVPNoci_vpnoci.resourceId(prefixocid1.ipsecconnection), nameoci.resourceName; one entity per IPSec connection (tunnels distinguished bypublicIpdimension)Golden Metrics
oci.vpn.tunnel.state)oci.vpn.bytes.sent/oci.vpn.bytes.received)oci.vpn.packets.error)Metric Source
https://docs.oracle.com/en-us/iaas/Content/Network/Reference/ipsecmetrics.htm
Validated locally with the repo's ajv schema validators + validate-folders + validate-rules (all pass).